fix(manager/uv): apply normalization on sources #31297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
changed the title
6 tasks
mkniewallner
force-pushed
the
fix/handle-normalization-uv-source
branch
from
ad5028f to
91177b5
Compare
mkniewallner
commented
Oct 27, 2024
secustor
reviewed
Oct 29, 2024
viceice
reviewed
Oct 29, 2024
6 tasks
viceice
approved these changes
Oct 29, 2024
secustor
approved these changes
Oct 29, 2024
|
🎉 This PR is included in version 38.134.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Apply normalisation when retrieving uv's sources, as uv itself does that when mapping a dependency to a specific source.
Context
This was discovered in #31270 (comment), but the PR was merged before this could be resolved.
The test moved from
uv.spec.tstoextract.spec.tsallows testing that the normalisation is applied on sources in the schema, which callingprocessor.processdoes not, as it happens after the normalisation.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: