Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(vite): fix firefox expected error detection #8093

Merged
merged 1 commit into from
Nov 21, 2023
Merged

test(vite): fix firefox expected error detection #8093

merged 1 commit into from
Nov 21, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Nov 21, 2023 •
edited
Loading

Ran this locally with:

yarn test:integration --project=firefox -g "vite-hmr"

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: cc4823c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit d9528a0 into dev Nov 21, 2023
@pcattori pcattori deleted the pedro/vite-test-fix-firefox-expected-error branch November 21, 2023 19:57
brophdawg11 pushed a commit that referenced this pull request Nov 22, 2023
@pcattori @brophdawg11
test(vite): fix firefox expected error detection (#8093)
45cc552
brophdawg11 pushed a commit that referenced this pull request Nov 29, 2023
@pcattori @brophdawg11
test(vite): fix firefox expected error detection (#8093)
1dcf5ff
brophdawg11 pushed a commit that referenced this pull request Nov 29, 2023
@pcattori @brophdawg11
test(vite): fix firefox expected error detection (#8093)
8b9215c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @markdalgleish