Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move @types/* to devDependencies #6051

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix: move @types/* to devDependencies #6051

merged 1 commit into from
Apr 12, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Apr 12, 2023 •
edited
Loading

@mcansh
fix: move @types/* to devDependencies
0380f03 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

⚠️ No Changeset found

Latest commit: 0380f03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh merged commit f449753 into dev Apr 12, 2023
@mcansh mcansh deleted the logan/move-types branch April 12, 2023 18:36
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 12, 2023
MichaelDeBoey
MichaelDeBoey reviewed Apr 12, 2023
View reviewed changes
packages/remix-server-runtime/package.json
"@web3-storage/multipart-parser": "^1.0.0",
"cookie": "^0.4.1",
"set-cookie-parser": "^2.4.8",
"source-map": "^0.7.3"
},
"devDependencies": {
"@remix-run/web-file": "^3.0.2",
"@types/cookie": "^0.4.0",
"@types/react": "^18.0.15",
Copy link
Member

@MichaelDeBoey MichaelDeBoey Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcansh We're exporting types that use @types/react, so we should keep this one in dependencies

It can be removed if we merge #5713 though

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-4be6e9d-20230413 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@haines haines mentioned this pull request May 2, 2023
Closed
1 task
@lpsinger lpsinger mentioned this pull request May 4, 2023
Closed
1 task
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 15, 2023
Merged
This was referenced May 23, 2023
Open
Closed
This was referenced Jun 12, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey left review comments

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcansh @MichaelDeBoey