Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(remix-tutorial): Add artificial delay to contact retrieval for demonstration #10475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kei-yamazaki
Copy link

Add Loading Delay to Contact Fetch Operation

Closes: # (no specific issue to close)

[x] Tests
[ ] Docs

Changes Made

Added a 500ms artificial delay to the getContact function to simulate network latency in the contact fetching operation. This change helps to demonstrate loading states in the UI more effectively during the tutorial.

Testing Strategy

This change can be tested by:

  1. Running the tutorial application
  2. Navigating to a contact's details page
  3. Verifying that there is a noticeable 500ms delay before the contact information appears
  4. Confirming that the loading state is properly displayed during this delay

The delay is implemented using a Promise-based setTimeout, which is a common pattern for simulating network conditions in demo applications.

Impact

This is a minor change that only affects the tutorial example and does not impact any core functionality. The delay is small enough to maintain a good user experience while being long enough to demonstrate loading states effectively.

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 1356335

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 11, 2025

Hi @kei-yamazaki,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 11, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant