Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add externals config for prop-types? #5045

Closed

Conversation

jochenberger
Copy link
Contributor

I think that you shouldn't package prop-types in the UMD modules.

@timdorr
Copy link
Member

timdorr commented Apr 27, 2017

This is technically proper, but I'm wondering how many people are just importing React/ReactDOM and will have a big breakage when this kind of thing lands.

@jochenberger
Copy link
Contributor Author

I wonder if we could provide a migration path.

@timdorr
Copy link
Member

timdorr commented Apr 27, 2017

It's all or nothing, unfortunately. The only other way around it is to hand-build the UMD version and hack in some sort of externals check to do a deprecation warning if it's not defined externally. But that seems really risky and brittle.

A minor release with this change shouldn't be a problem. Most UMD consumers should be able to manage their deps in some way, so they should see the requirement for prop-types and add that in.

@mjackson
Copy link
Member

I think we'll continue to leave prop-types in our build for now. Thanks for the suggestion though, @jochenberger :)

@mjackson mjackson closed this Jul 15, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants