Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #374 & #375 #376

Closed
wants to merge 5 commits into from
Closed

fix #374 & #375 #376

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2018

Closes #374
Closes #375

There's a newly added test can't pass the stringify. It seems that there's a bug in remark-stringify, which I'm not familiar with.

wooorm added a commit that referenced this pull request Nov 10, 2018
@wooorm @ruihe774
remark: fix escaping of backslash
40ec693 
Closes GH-375.
Related-to GH-376.

Co-authored-by: TitanSnow <sweeto@live.cn>
wooorm added a commit that referenced this pull request Nov 10, 2018
@wooorm @ruihe774
remark-parse: fix headings with content hashes
c55e4a3 
Closes GH-374.
Related to GH-376.

Co-authored-by: TitanSnow <sweeto@live.cn>
@wooorm
Copy link
Member

wooorm commented Nov 10, 2018

@titansnow thank you so much! I split both PRs so that it’s more readable, and I think your heading fix could be more readable (like so), but you’re credited as a co-author.

🥳

@wooorm wooorm closed this Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wooorm @ruihe774