-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update flightcontrol deploy config #6494
Conversation
Thanks for the update @flybayer 👍🏻 should be merged in no time. |
@jtoar just wanted to double check on this one, I added the |
@noire-munich Yes, fixture-ok is the right choice. Our test project doesn't use this file and isn't affected by this change in any way. If you're unsure it's always okay to just rebuild the test project fixture and commit the changes. That label is just a quick way around having to do that if you know it's not really needed |
Thanks @Tobbe ! This confirms how I thought about it, it's good to know 👍 |
Thanks @noire-munich! Yeah let's get this merged so we can hand it off to the deploy target CI repo. |
We have a new nixpacks build option that automatically detects package manager versions, node versions, etc. So install command is no longer needed and no longer need to manually install yarn stable version.