Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: "Re-enable TypeScript tests"
about: Testing is important
PR Type
Does this PR add a new feature, or fix a bug?
Internal change.
Why should this PR be included?
See #3500 (comment) and following. I tried out
tsd
, but I did not like it as much. Theexpect()
method syntax made it more cumbersome to assert in some scenarios. It also wasn't very well documented. I had to read the source code to figure out how to use it. So, I think sticking withtypings-tester
is preferable for now.Note, I also needed to add an import in
types\store.ts
in order to get the globalSymbol.observable
definition working in the type outputs.Checklist
Bug Fixes
What is the current behavior, and the steps to reproduce the issue?
Types can break.
What is the expected behavior?
The ability to test types.
How does this PR fix the problem?
Re-enables types testing.