Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm format fails on Windows #2828

Closed
sstarrAtmeta opened this issue Feb 8, 2018 · 2 comments
Closed

npm format fails on Windows #2828

sstarrAtmeta opened this issue Feb 8, 2018 · 2 comments

Comments

@sstarrAtmeta
Copy link

Do you want to request a feature or report a bug?
bug

npm format fails on Windows
[error] No matching files. Patterns tried: '{src,test}/**/*.js' !**/node_modules/** !./node_modules/**
npm-debug.log states the following fails:
prettier --write '{src,test}/**/*.js'
Prettier and options appear to have been added in this pull request: #2676

Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?

format command was not present in v3.7.2. However, build succeeded in v3.7.2 but does not in my current version.

Current versions:
Redux version "4.0.0-beta.1"
Microsoft Windows [Version 10.0.16299.192]
node v8.9.4
npm 5.6.0

@timdorr
Copy link
Member

timdorr commented Feb 8, 2018

Is there a cross-platform globbing tool we can use?

@eps1lon
Copy link
Contributor

eps1lon commented Feb 8, 2018

No need for that. The glob pattern syntax was wrong. PR is under way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants