Fix k3d package simultaneous booting #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up a bug in the k3d package that causes
startupManifeststo fail to apply objects on subsequent cluster creation due toclient.Patchunmarshaling semantics and the fact that we were using a singleton. Rather than move off of a singleton, this just dups the objects we're patching so that we never havemeta.managedFieldsset. Without theDeepCopyObjectcall the added tests fails most of the time with:Additionally this adds some customization options for a cluster in case you don't actually need a full 3 nodes, want to use a custom image, timeout, etc.