enable importas and stylecheck linters
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
approved these changes
Nov 4, 2024
chrisseto
force-pushed
the
chris/p/update-linters
branch
2 times, most recently
from
e190ee8 to
fbca098
Compare
Prior to this commit is was possible for double imports to accidentally go unnoticed. This commit enables the `stylecheck` linter, which catches double imports as well as other minor style issues; enables `importas`, to enforce consistent importing of kubernetes' "versioned" packages; and corrects any discovered issues.
chrisseto
force-pushed
the
chris/p/update-linters
branch
from
fbca098 to
f9fb318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit is was possible for double imports to accidentally go unnoticed.
This commit enables the
stylechecklinter, which catches double imports as well as other minor style issues; enablesimportas, to enforce consistent importing of kubernetes' "versioned" packages; and corrects any discovered issues.