Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm-chart version #165

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Bump helm-chart version #165

merged 1 commit into from
Jul 1, 2024

Conversation

chrisseto
Copy link
Contributor

This commit updates the helm-charts dependency to the latest commit (redpanda-data/helm-charts@7d1ab26) which includes fixes to the generated PartialValues type.

It also re-enables a hand full of fields on the TestHelmvaluesCompat that we're failing due to the incorrectly generated type.

The now re-enabled tests found a mild mistyping in PersistentVolume.Size which has been "upgraded" to a resource.Quantity type.

This commit updates the helm-charts dependency to the latest commit
(redpanda-data/helm-charts@7d1ab26)
which includes fixes to the generated `PartialValues` type.

It also re-enables a hand full of fields on the `TestHelmvaluesCompat` that
we're failing due to the incorrectly generated type.

The now re-enabled tests found a mild mistyping in `PersistentVolume.Size`
which has been "upgraded" to a `resource.Quantity` type.
@chrisseto chrisseto requested a review from RafalKorepta as a code owner June 27, 2024 14:47
@chrisseto chrisseto merged commit d9e2a57 into main Jul 1, 2024
4 checks passed
@chrisseto chrisseto deleted the chris/p/bump-chart-types branch July 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants