Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dutch translations to GLPI-AgentMonitor.rc #26

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Added Dutch translations to GLPI-AgentMonitor.rc #26

merged 4 commits into from
Jul 10, 2024

Conversation

perplexityjeff
Copy link
Contributor

Hi,

I've added a basic Dutch translation. I hope I've done it correctly :).

Let me know!

Thank you,

Jeff

Added Dutch translations to GLPI-AgentMonitor.rc
Added Dutch translations to GLPI-AgentMonitor.rc
@redddcyclone
Copy link
Owner

Hi @perplexityjeff

First of all, thanks for the contribution!

Didn't you miss some strings? Like "View agent logs", "Start service" and "Stop service"? Or were they intended to be left like this?

Changed 'View Agent logs' as that was missed
@perplexityjeff
Copy link
Contributor Author

perplexityjeff commented Jul 10, 2024

Hi @redddcyclone,

I missed the "View agent logs" strings my bad, I made a commit to change it. "Start service" and "Stop service" works in Dutch as well as English (imo).

Also I made some assumptions about this code:

#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_NLD) LANGUAGE LANG_DUTCH, SUBLANG_DUTCH

I hope I did it correctly, if not let me know!

Changed 'View Agent logs' as that was missed
@perplexityjeff
Copy link
Contributor Author

Changed capitilization from 'Agent' to 'agent'.

@redddcyclone
Copy link
Owner

Hi @perplexityjeff

I tested it setting the locale to Dutch and it did work fine. Also, is "Service status" OK in english too?

@perplexityjeff
Copy link
Contributor Author

Hi @redddcyclone,

Service status is fine in Dutch as well as in English :) (imo).

@redddcyclone redddcyclone merged commit 017724c into redddcyclone:main Jul 10, 2024
3 checks passed
@redddcyclone
Copy link
Owner

@perplexityjeff

OK, the translation has been merged. Thanks a lot for your contribution!

@perplexityjeff perplexityjeff deleted the patch-1 branch July 10, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants