Implement CR deletion using OpenshiftLibrary instead of UI #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
bdattoma
added
needs testing
bdattoma
requested review from
jgarciao,
pablofelix,
mwaykole,
lugi0 and
tarukumar
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
lugi0
previously approved these changes
Jan 27, 2023
Signed-off-by: bdattoma <bdattoma@redhat.com>
| ${pachyderm_container_name} Pachyderm | ||
| ${pachyderm_operator_name} Pachyderm | ||
| ${pachyderm_appname} pachyderm | ||
| ${pachyderm_ns} pachyderm |
Check warning
Code scanning / Robocop
Section variable '{{ variable_name }}' name should be uppercase
Signed-off-by: bdattoma <bdattoma@redhat.com>
Robot Results
|
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
|
Jenkins job for ODS-760, ODS-675, ODS-1137 and ODS-1161: 1538 SUCCESS |
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
bdattoma
added
verified
lugi0
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tier2 runs we see often failing the step of deleting ISV's CustomResource, so this PR wants to improve that by replacing UI navigation with CLI for performing that step.
For pachyderm, it also replaces project creation/deletion with OpenshftiLibrary since it is a ery easy and quick change.
This is just a first piece of the final implementation where the install/uninstall process of ISV will be completely done via CLI instead UI.
A note about openvino
You'll see the code for Openvino is slightly different, because the default CR name is tide to a version (i.e., v2022.3), so there is an higher probability this could change over time and our teardown would fails. So, until we get to Install using CLI (where we will input the CR name), the Openvino teardown will delete all the CR instances of openvino. In theory, there should be only one which was created by the test itself.
Adding now the input of a custom CR name (or just fetching the default one from the UI) would add just an additional point of failure in the UI testing which is not very stable over OCP versions