Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Save changes" keyword and ODS-488 #684

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fix "Save changes" keyword and ODS-488 #684

merged 2 commits into from
Jan 30, 2023

Conversation

bdattoma
Copy link
Contributor

PR to fix 2 automation bugs found in 1.22 run:

  1. kw to fetch header text from sidebars (ODS-488)
  2. kw to save dashboard settings (affecting many TCs)

@bdattoma
fix header text check - ODS-488
1b10152 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
fix save changes kw
8f0d34a 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Jan 26, 2023
@bdattoma bdattoma self-assigned this Jan 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
284 0 0 284 100

@bdattoma
Copy link
Contributor Author

bdattoma commented Jan 26, 2023 •
edited
Loading

Jenkins Job testing ODS-488,ODS-1218,ODS-1220,ODS-1788,ODS-1684: 1532 SUCCESS All the test passed, the failure you see is a suite teardown which was expecting Jupyter to be open. But I didn't run the test which is supposed to open jupyter in that suite, so that's okay.

@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jan 26, 2023
lugi0
lugi0 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jgarciao
jgarciao approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdattoma bdattoma merged commit 7d453d0 into red-hat-data-services:master Jan 30, 2023
@bdattoma bdattoma deleted the fix_sanity122 branch November 6, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@lugi0 lugi0 lugi0 approved these changes

@pablofelix pablofelix Awaiting requested review from pablofelix

@mwaykole mwaykole Awaiting requested review from mwaykole

@tarukumar tarukumar Awaiting requested review from tarukumar

Assignees

@bdattoma bdattoma

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdattoma @jgarciao @lugi0