-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed self-managed installer support and added support to install RHODS from Operatorhub #678
Removed self-managed installer support and added support to install RHODS from Operatorhub #678
Conversation
Signed-off-by: Tarun Kumar <takumar@redhat.com>
Signed-off-by: Tarun Kumar <takumar@redhat.com>
Signed-off-by: Tarun Kumar <takumar@redhat.com>
Signed-off-by: Tarun Kumar <takumar@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
Signed-off-by: Tarun Kumar <takumar@redhat.com>
Kudos, SonarCloud Quality Gate passed!
|
Install:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR make following changes to support below:
Removed support for self-managed installer.
Added variable based on SM and operatorhub install for self-managed
Added support to install and uninstall for self-manged rhods cluster using olminstall repo
Modified install verification keyword
For now you can run :
sh run_robot_test.sh --include install --test-variable image_url: --test-variable RHODS_OSD_INSTALL_REPO: --test-variable cluster_type:managed --test-variable TEST_ENV:GCP --test-case tasks/Tasks/rhods_olm.robot
uninstall:
sh run_robot_test.sh --include uninstall --test-variable RHODS_OSD_INSTALL_REPO: --test-variable cluster_type:managed --test-case tasks/Tasks/rhods_olm.robot