Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed self-managed installer support and added support to install RHODS from Operatorhub #678

Merged
merged 20 commits into from
Jan 19, 2023

Conversation

tarukumar
Copy link
Contributor

This PR make following changes to support below:
Removed support for self-managed installer.
Added variable based on SM and operatorhub install for self-managed
Added support to install and uninstall for self-manged rhods cluster using olminstall repo
Modified install verification keyword

For now you can run :
sh run_robot_test.sh --include install --test-variable image_url: --test-variable RHODS_OSD_INSTALL_REPO: --test-variable cluster_type:managed --test-variable TEST_ENV:GCP --test-case tasks/Tasks/rhods_olm.robot

uninstall:

sh run_robot_test.sh --include uninstall --test-variable RHODS_OSD_INSTALL_REPO: --test-variable cluster_type:managed --test-case tasks/Tasks/rhods_olm.robot

@tarukumar tarukumar requested a review from pablofelix January 19, 2023 08:16
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
279 0 0 279 100

Signed-off-by: Tarun Kumar <takumar@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tarukumar
Copy link
Contributor Author

Install:
`Installing RHODS operator in selfmanaged
.Verifying RHODS installation
pod operator created
pods rhods-dashboard created
pods notebook-controller created
pods odh-notebook-controller created
Verified redhat-ods-applications
Verified redhat-ods-operator
Verified redhat-ods-monitoring
RHODS has been installed
Can Install RHODS Operator | PASS |

Rhods Olm :: Perform and verify RHODS OLM tasks | PASS |
1 task, 1 passed, 0 failed

Output: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-29-dhvANce0gh/output.xml
XUnit: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-29-dhvANce0gh/xunit_test_result.xml
Log: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-29-dhvANce0gh/log.html
Report: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-29-dhvANce0gh/test_report.html
`

Uninstall:

`Uninstalling RHODS operator in selfmanaged
Removing RHODS... Be patient...
kfdef.kfdef.apps.kubeflow.org "rhods-notebooks" deleted
kfdef.kfdef.apps.kubeflow.org "modelmesh-monitoring" deleted
kfdef.kfdef.apps.kubeflow.org "monitoring" deleted
kfdef.kfdef.apps.kubeflow.org "rhods-anaconda" deleted
kfdef.kfdef.apps.kubeflow.org "rhods-dashboard" deleted
kfdef.kfdef.apps.kubeflow.org "rhods-model-mesh" deleted
kfdef.kfdef.apps.kubeflow.org "rhods-nbc" deleted
namespace "rhods-notebooks" deleted
namespace "redhat-ods-monitoring" deleted
namespace "redhat-ods-applications" deleted
namespace "redhat-ods-operator" deleted
customresourcedefinition.apiextensions.k8s.io "kfdefs.kfdef.apps.kubeflow.org" deleted
.redhat-ods-monitoring deleted
redhat-ods-applications deleted
redhat-ods-operator deleted
RHODS has been uninstalled
Can Uninstall RHODS Operator | PASS |

Rhods Olm :: Perform and verify RHODS OLM tasks | PASS |
1 task, 1 passed, 0 failed

Output: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-22-yMJsvLJkA7/output.xml
XUnit: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-22-yMJsvLJkA7/xunit_test_result.xml
Log: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-22-yMJsvLJkA7/log.html
Report: /home/takumar/Development/ods-ci/test-output/ods-ci-2023-01-19-13-22-yMJsvLJkA7/test_report.html
`

@tarukumar
Copy link
Contributor Author

image

Copy link
Contributor

@pablofelix pablofelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar merged commit 4655e94 into red-hat-data-services:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants