Add test for tolerations on workbeches #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
bdattoma
added
needs testing
bdattoma
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Robocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Jenkins job for ODS-1969: 1515 SUCCESS Jenkisn Job for Smoke: 1519 SUCCESS Jenkins Job for specific test cases affected by refactoring: 100 3 failures not related to the changes in this PR |
bdattoma
added
verified
mwaykole
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ODS-1969 (tolerations on workbenches).
Moreover, it applies a refactor to create a single resource file to gather keywords for habdling RHODS > Settings UI