Fix keyword to check if RHODS is Self managed #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdattoma
added
needs testing
bdattoma
requested review from
jgarciao,
pablofelix,
mwaykole,
lugi0 and
tarukumar
|
Kudos, SonarCloud Quality Gate passed!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ... name=addon-managed-odh-catalog | ||
| ... namespace=redhat-ods-operator | ||
| IF ${is_managed} == ${TRUE} | ||
| ${is_self_managed}= Set Variable ${FALSE} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead
| IF ${is_managed} == ${TRUE} | ||
| ${is_self_managed}= Set Variable ${FALSE} | ||
| ELSE | ||
| ${is_self_managed}= Set Variable ${TRUE} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead
Robot Results
|
tarukumar
approved these changes
Dec 21, 2022
bdattoma
added
verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self managed catalog source has changed (at least when RHODS is installed using olm script) so our tests are broken. The fix consists in trying to fetch the managed service addon, and if it doesn't exist, then RHODS is self managed