Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keyword to wait for dashboard and remove Seldon folder #658

Merged
merged 12 commits into from
Dec 22, 2022
Merged

Improve keyword to wait for dashboard and remove Seldon folder #658

merged 12 commits into from
Dec 22, 2022

Conversation

bdattoma
Copy link
Contributor

@bdattoma bdattoma commented Dec 19, 2022 •
edited
Loading

we've notice some rare failures in waiting until the dashboard is loaded (the RHODS log was loaded but the rest of the page like cards were not).

The PR is adding 2 fixes:

  1. Wait until the expected page title (h1) is loaded, e.g., Explore.
  2. Wait until the applications' cards are loaded - OPTIONAL

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Dec 19, 2022
@bdattoma bdattoma self-assigned this Dec 19, 2022
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
279 0 0 279 100

lugi0
lugi0 previously approved these changes Dec 19, 2022
View reviewed changes
jgarciao
jgarciao previously approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgarciao jgarciao added the do not merge Do not merge this yet please label Dec 21, 2022
@jgarciao jgarciao dismissed their stale review December 21, 2022 10:22

agreed like this

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2022
View reviewed changes
tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
IF ${wait_for_cards} == ${TRUE}
Wait Until Cards Are Loaded
END

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line

Trailing whitespace at the end of line
tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
[Return] ${apps_dict_obj}

Wait Until Cards Are Loaded
Wait Until Page Contains Element xpath://div[contains(@class,'odh-explore-apps__gallery')]
Wait Until Page Contains Element xpath://div[contains(@class,'-apps__gallery')]

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line

Trailing whitespace at the end of line
tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Wait For Condition return document.title == ${dashboard_title} timeout=15s
Wait Until Page Contains Element xpath:${RHODS_LOGO_XPATH} timeout=15s
IF ${wait_for_cards} == ${TRUE}

Check notice

Code scanning / Robocop

IF can be replaced with inline IF

IF can be replaced with inline IF
@bdattoma bdattoma changed the title Add wait for spinner in RHOAM smoke and remove Seldon folder Improve keyword to wait for dashboard and remove Seldon folder Dec 21, 2022
@bdattoma
Copy link
Contributor Author

bdattoma commented Dec 21, 2022 •
edited
Loading

Jenkins Job 1: testing through ODS-293, ODS-262 and ODS-248 1458 SUCCESS

Jenkins Job 2: testing through DS Projects suite: 1461 SUCCESS with a failure The failure is due to a DS project already present in the cluster before running the test, so that's OKAY

@bdattoma bdattoma removed the do not merge Do not merge this yet please label Dec 21, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2022
View reviewed changes
tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
@@ -123,7 +129,8 @@
[Documentation] Verify the service appears in Applications > Explore
[Arguments] ${app_name}
Menu.Navigate To Page Applications Explore
Wait Until Page Contains Jupyter timeout=30
# Wait Until Page Contains Jupyter timeout=30
Wait for RHODS Dashboard to Load expected_page=Explore

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Wait for RHODS Dashboard to Load' does not follow case convention
tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Projects.resource
Click Link Data Science Projects
Wait for RHODS Dashboard to Load wait_for_cards=${FALSE} expected_page=Data science projects

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Wait for RHODS Dashboard to Load' does not follow case convention
lugi0
lugi0 previously approved these changes Dec 21, 2022
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2022
View reviewed changes
tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Wait For Condition return document.title == ${dashboard_title} timeout=15s
Wait Until Page Contains Element xpath:${RHODS_LOGO_XPATH} timeout=15s
IF "${expected_page}" != "${NONE}"
Wait Until Page Contains Element xpath://h1[text()="${expected_page}"]

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line

Trailing whitespace at the end of line
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2022
View reviewed changes
tests/Tests/500__jupyterhub/jupyterhub-user-access.robot
@@ -124,7 +126,8 @@
Capture Page Screenshot perm_admin_custom.png
Logout From RHODS Dashboard
Login To RHODS Dashboard ${TEST_USER_3.USERNAME} ${TEST_USER_3.PASSWORD} ${TEST_USER_3.AUTH_TYPE}
Wait for RHODS Dashboard to Load
Wait for RHODS Dashboard to Load expected_page=Start a notebook server

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Wait for RHODS Dashboard to Load' does not follow case convention
tests/Tests/500__jupyterhub/jupyterhub-user-access.robot
@@ -139,7 +142,8 @@
Capture Page Screenshot perm_admin_std.png
Logout From RHODS Dashboard
Login To RHODS Dashboard ${TEST_USER_4.USERNAME} ${TEST_USER_4.PASSWORD} ${TEST_USER_4.AUTH_TYPE}
Wait for RHODS Dashboard to Load
Wait for RHODS Dashboard to Load expected_page=Start a notebook server

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Wait for RHODS Dashboard to Load' does not follow case convention
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 21, 2022
View reviewed changes
tests/Resources/Page/ODH/ODHDashboard/ODHDashboard.robot
Open Browser ${dashboard_url} browser=${browser} options=${browser_options}
Login To RHODS Dashboard ${ocp_user_name} ${ocp_user_pw} ${ocp_user_auth_type}
Wait for RHODS Dashboard to Load
Wait for RHODS Dashboard to Load expected_page=${expected_page}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention

Keyword name 'Wait for RHODS Dashboard to Load' does not follow case convention
@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Dec 22, 2022
@jgarciao jgarciao self-requested a review December 22, 2022 12:42
jgarciao
jgarciao previously approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bdattoma bdattoma requested review from jgarciao and lugi0 December 22, 2022 14:56
jgarciao
jgarciao approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdattoma bdattoma merged commit 8d84096 into red-hat-data-services:master Dec 22, 2022
@bdattoma bdattoma deleted the fix_isv_check branch January 5, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@lugi0 lugi0 lugi0 approved these changes

@aloganat aloganat Awaiting requested review from aloganat

@pablofelix pablofelix Awaiting requested review from pablofelix

@mwaykole mwaykole Awaiting requested review from mwaykole

@tarukumar tarukumar Awaiting requested review from tarukumar

Assignees

@bdattoma bdattoma

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdattoma @jgarciao @lugi0