Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for deploying/uninstalling rhods in GCP cluster #613

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Support for deploying/uninstalling rhods in GCP cluster #613

merged 8 commits into from
Nov 8, 2022

Conversation

tarukumar
Copy link
Contributor

Added support for self-managed GCP

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tarukumar tarukumar requested a review from pablofelix November 3, 2022 04:34
@tarukumar tarukumar self-assigned this Nov 3, 2022
@tarukumar tarukumar added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
250 0 0 250 100

pablofelix
pablofelix approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@pablofelix pablofelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aloganat
Copy link
Contributor

aloganat commented Nov 7, 2022

Hi @tarukumar Could you modify the PR summary to "Support for deploying/uninstalling rhods in GCP cluster".
Code looks good to me.

@tarukumar tarukumar changed the title Self managed gcp support Support for deploying/uninstalling rhods in GCP cluster Nov 7, 2022
mwaykole
mwaykole approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@mwaykole mwaykole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar merged commit 4e59194 into red-hat-data-services:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablofelix pablofelix pablofelix approved these changes

@mwaykole mwaykole mwaykole approved these changes

Assignees

@tarukumar tarukumar

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarukumar @aloganat @pablofelix @mwaykole