Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add support to perform OSD upgrade" #610

Merged
merged 11 commits into from
Oct 31, 2022

Conversation

mwaykole
Copy link
Member

Signed-off-by: mwaykole mwaykole@redhat.com

Signed-off-by: mwaykole <mwaykole@redhat.com>
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
250 0 0 250 100

Signed-off-by: mwaykole <mwaykole@redhat.com>
@mwaykole mwaykole requested a review from aloganat October 28, 2022 18:20
@mwaykole
Copy link
Member Author

tested full flow http://10.70.37.205:8080/job/rhods-master-job/26/

@mwaykole mwaykole self-assigned this Oct 29, 2022
@mwaykole mwaykole added the verified This PR has been tested with Jenkins label Oct 29, 2022
Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u address the sonarcloud failure.

Signed-off-by: mwaykole <mwaykole@redhat.com>
Signed-off-by: mwaykole <mwaykole@redhat.com>
tarukumar
tarukumar previously approved these changes Oct 31, 2022
@tarukumar
Copy link
Contributor

@milind i have approved it but please check the black linter action log. it has failures

@tarukumar tarukumar self-requested a review October 31, 2022 08:26
Signed-off-by: mwaykole <mwaykole@redhat.com>
Signed-off-by: mwaykole <mwaykole@redhat.com>
@mwaykole mwaykole changed the title Add_ods_upgrade_cmd in ocm.py Add_osd_upgrade_cmd in ocm.py Oct 31, 2022
Signed-off-by: mwaykole <mwaykole@redhat.com>
Signed-off-by: mwaykole <mwaykole@redhat.com>
Signed-off-by: mwaykole <mwaykole@redhat.com>
Signed-off-by: mwaykole <mwaykole@redhat.com>
@mwaykole mwaykole changed the title Add_osd_upgrade_cmd in ocm.py "Add support to perform OSD upgrade" Oct 31, 2022
@mwaykole mwaykole requested a review from aloganat October 31, 2022 09:58
Signed-off-by: mwaykole <mwaykole@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mwaykole mwaykole merged commit 2e0ffc7 into red-hat-data-services:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants