Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failures in Dashboard API testing #575

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Fix failures in Dashboard API testing #575

merged 4 commits into from
Sep 29, 2022

Conversation

bdattoma
Copy link
Contributor

3 fixes:

  1. test for pvc endpoint requires a test setup to remove all the notebooks and pvc for the test users, if those were created by earlier tests
  2. nb-events has introduced a security fix that require our test to change the expected behavior of some calls
  3. notebooks endpoint requires the same changes of 2)

Signed-off-by: bdattoma bdattoma@redhat.com

@bdattoma
add pvc setup + fix nb-events and notebooks
39b1aad 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) do not merge Do not merge this yet please labels Sep 26, 2022
@bdattoma bdattoma self-assigned this Sep 26, 2022
@bdattoma
continue if pvc setup fails + rolebinding fix
49d6183 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
fix attempt for initial clean up in PVC test
6ee0688 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Sep 26, 2022
@bdattoma
Copy link
Contributor Author

Jenkins Job #1301 SUCCESS

@bdattoma bdattoma removed the do not merge Do not merge this yet please label Sep 28, 2022
@bdattoma bdattoma requested a review from jgarciao September 28, 2022 09:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tarukumar
tarukumar approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@tarukumar tarukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdattoma bdattoma merged commit d5134f7 into red-hat-data-services:master Sep 29, 2022
@bdattoma bdattoma deleted the api_vul_2 branch January 5, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@lugi0 lugi0 lugi0 left review comments

@tarukumar tarukumar tarukumar approved these changes

@mwaykole mwaykole Awaiting requested review from mwaykole

@pablofelix pablofelix Awaiting requested review from pablofelix

Assignees

@bdattoma bdattoma

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdattoma @jgarciao @lugi0 @tarukumar