Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ODS-650 to Anaconda e2e test case #570

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Add ODS-650 to Anaconda e2e test case #570

merged 6 commits into from
Sep 28, 2022

Conversation

bdattoma
Copy link
Contributor

Adding two additional checks in the Anaconda E2E test case.
Signed-off-by: bdattoma bdattoma@redhat.com

@bdattoma bdattoma added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Sep 20, 2022
@bdattoma bdattoma self-assigned this Sep 20, 2022
@bdattoma
Copy link
Contributor Author

JenkinsJob 1289 SUCCESS with a failure in teardown. I think it's just a timing issue while checking if the build object has been deleted. I've checked the cluster after and it was clean.
I've added a small sleep and will run once again.

However the changes from this PR have been validated in the jenkins run

@bdattoma bdattoma added verified This PR has been tested with Jenkins needs testing Needs to be tested in Jenkins and removed needs testing Needs to be tested in Jenkins verified This PR has been tested with Jenkins labels Sep 21, 2022
jgarciao
jgarciao previously approved these changes Sep 23, 2022
View reviewed changes
@bdattoma
add ODS-650
94c8d92 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
remove newlines from expected values
8f31894 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
add sleep in BuildConfig deletion
d74653a 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
remove prod bug tag
a11d22a 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
replace sleep
8905450 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@bdattoma
replace go to
a74a384 
Signed-off-by: bdattoma <bdattoma@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bdattoma
Copy link
Contributor Author

image

@bdattoma bdattoma added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Sep 26, 2022
lugi0
lugi0 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one doubt

@bdattoma bdattoma requested a review from jgarciao September 27, 2022 16:04
@jgarciao jgarciao merged commit da7f7ee into red-hat-data-services:master Sep 28, 2022
@bdattoma bdattoma deleted the ace_tcs branch September 29, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lugi0 lugi0 lugi0 approved these changes

@jgarciao jgarciao jgarciao approved these changes

@pablofelix pablofelix Awaiting requested review from pablofelix

@mwaykole mwaykole Awaiting requested review from mwaykole

@tarukumar tarukumar Awaiting requested review from tarukumar

Assignees

@bdattoma bdattoma

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdattoma @jgarciao @lugi0