Workaround for modal not appearing during spawn #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
lugi0
added
enhancements
bdattoma
previously approved these changes
Sep 7, 2022
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
jgarciao
approved these changes
Sep 8, 2022
bdattoma
approved these changes
Sep 8, 2022
kpouget
reviewed
Sep 9, 2022
Comment on lines
+138
to
+139
| IF ${modal}==False | ||
| Log message=Starting server modal didn't appear after 60s level=ERROR |
There was a problem hiding this comment.
There was a problem hiding this comment.
this line would raise a red light since the level is set to ERROR. @lugi0 right?
There was a problem hiding this comment.
it will raise the red flag ... but only after 60s. The popup should appear "immediately".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Giorgi lgiorgi@redhat.com