Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify cuda buildchain in smoke pipeline #502

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Verify cuda buildchain in smoke pipeline #502

merged 4 commits into from
Aug 22, 2022

Conversation

jgarciao
Copy link
Contributor

  • Fix keyword Wait Until All Builds Are Complete to iterate the buildconfigs instead of the builds
  • Add Verify That CUDA Build Chain Succeeds to smoke.
    • Previously this test was called Verify Pytorch And Tensorflow Can Be Spawned but that test doesn't exist in Polarion anymore and neither the polarion id's ODS-480 and ODS-481

@jgarciao
Fix keyword "Wait Until All Builds Are Complete"
3aa5afb 
Previously the keyword "Wait Until All Builds Are Complete" was iterating
the list of builds, but if the build wasn't already created it didn't wait
for it to be in state Complete

To fix this, we use the buildconfigs instead

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Add "Verify That CUDA Build Chain Succeeds" to smoke
2d98373 
Previously this test was called "Verify Pytorch And Tensorflow Can Be Spawned"
but that test doesn't exist in Polarion anymore. Same for polarion id's
ODS-480 and ODS-481

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Aug 18, 2022
@jgarciao
Fix "Wait Until All Builds Are Complete" when build doesn't exist
2c08b32 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao force-pushed the verify-cuda-buildchain-in-smoke-pipeline branch from 674f571 to 2c08b32 Compare August 19, 2022 08:58
@jgarciao
Copy link
Contributor Author

Tested here: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/1169

  • Wait Until All Builds Are Complete worked well and waited until all builds were finished and in status = Complete
  • Verify Image Can Be Spawned image=minimal-gpu, size=Default because of current issue RHODS-4934

@jgarciao jgarciao added verified This PR has been tested with Jenkins ⚠️ high priority review I need this to be reviewed ASAP and removed needs testing Needs to be tested in Jenkins labels Aug 19, 2022
@bdattoma
Copy link
Contributor

the keyword Wait Until All Builds Are Complete is used also by ODS-480 and ODS-307. Could you test if those TCs are impacted by the changes in this PR?
Note. very likely both the TCs will fail because other bugs, but at least the part where they check the build should pass

@jgarciao
Copy link
Contributor Author

jgarciao commented Aug 19, 2022 •
edited
Loading

the keyword Wait Until All Builds Are Complete is used also by ODS-480 and ODS-307. Could you test if those TCs are impacted by the changes in this PR? Note. very likely both the TCs will fail because other bugs, but at least the part where they check the build should pass

ODS-480 was removed by this PR because it doesn't exist in Polarion. I've tested the PR again including ODS-316 and ODS-307:

Tested again after fixing the cuda buildchain:

bdattoma
bdattoma previously approved these changes Aug 22, 2022
View reviewed changes
@jgarciao
Add tag ODS-481 to "Verify That CUDA Build Chain Succeeds"
951076a 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao merged commit 99fb03f into red-hat-data-services:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablofelix pablofelix pablofelix approved these changes

@bdattoma bdattoma bdattoma approved these changes

@tarukumar tarukumar Awaiting requested review from tarukumar

@mwaykole mwaykole Awaiting requested review from mwaykole

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins ⚠️ high priority review I need this to be reviewed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgarciao @bdattoma @pablofelix @mwaykole