Fix dsp tests on interop 2.17 & fix variable conflict in Permissions provoking xpath issue #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed when running the tests with the interop pipeline Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
`${SAVE_BUTTON}` is also defined in ODHDashboardSettings.resource that
value was used, provoking an xpath error when setting permissions
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
|
jgarciao
added
the
enhancements
jiripetrlik
approved these changes
Feb 7, 2025
bdattoma
approved these changes
Feb 7, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bdattoma, jgarciao, jiripetrlik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jgarciao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_userparameter for compatibility with the interop pipelineCurrently being tested in rhoai-test-flow/2751