Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disbale kueue to run ray e2e tests #2217

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ChughShilpa
Copy link
Contributor

Disbale kueue to run ray e2e tests to avoid ValidatingAdmissionPolicy check

@ChughShilpa
Copy link
Contributor Author

Test passed in rhoai-test-flow/2740

@abhijeet-dhumal
Copy link
Contributor

/lgtm
Thank you!

@jiripetrlik
Copy link
Contributor

Hello @ChughShilpa why do we need to disable Kueue? Is there any issue related to it?

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sutaakar
Copy link
Contributor

sutaakar commented Feb 7, 2025

@jiripetrlik The reason is that KubeRay upstream e2e tests don't use Kueue, so they don't contain local queue label.
As a result Kueue ValidatingAdmissionPolicy blocks RayClusters created by e2e tests.

Disabling Kueue avoids ValidatingAdmissionPolicy issue.

@jiripetrlik
Copy link
Contributor

@sutaakar Thank you, makes sense to me.

Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChughShilpa, jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 10, 2025

New changes are detected. LGTM label has been removed.

@sutaakar sutaakar merged commit ae896a3 into red-hat-data-services:master Feb 10, 2025
11 of 12 checks passed
@ChughShilpa ChughShilpa deleted the disable_kueue branch February 18, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants