[fix] the Verify Notebook Has Not Restarted upgrade test #2173
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # Get the notebook pod creation timestamp | ||
| ${notebook_pod_name}= Set Variable jupyter-nb-ldap-2dadmin2-0 | ||
| ${return_code} ${ntb_creation_timestamp} = Run And Return Rc And Output |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| Should Be Equal As Integers ${return_code} 0 msg=${ntb_creation_timestamp} | ||
|
|
||
| # Save the timestamp to the OpenShift ConfigMap so it can be used in test in the next phase | ||
| ${return_code} ${cmd_output} = Run And Return Rc And Output |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| ${return_code} ${cmd_output} = Run And Return Rc And Output | ||
| ... oc create namespace ${UPGRADE_NS} | ||
| Should Be Equal As Integers ${return_code} 0 msg=${cmd_output} | ||
| ${return_code} ${cmd_output} = Run And Return Rc And Output |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
Robot Results
|
jstourac
force-pushed
the
fixUpgradeTests
branch
from
b96252d to
3f883b1
Compare
This refactores this test - the first test part is moved to "pre_upgrade" phase, because this phase is run on the pre-upgrade version with the pre-upgrade code-base (branch). This is crucial since the further phases will be run with the code-base of the upgraded product and we may hit some issues in the differences in the product otherwise. There are done other changes and fixes to the test to make it more robust including the notebook deletion in the post upgrade phase. Apart from that, to propagate the timestamp value between the phases, this introduces a configmap in the "upgrade" namespace, where we can put some context that should be passed to the followup phase.
jstourac
force-pushed
the
fixUpgradeTests
branch
from
3f883b1 to
0b50a42
Compare
|
| @@ -178,10 +178,9 @@ | |||
| Should Match "${ls_server}" "${EMPTY}" | |||
|
|
|||
| Get User Notebook Pod Name | |||
| [Documentation] Returns notebook pod name for given username (e.g. for user ldap-admin1 it will be jupyterhub-nb-ldap-2dadmin1) | |||
| [Documentation] Returns notebook pod name for given username (e.g. for user ldap-admin1 it will be jupyter-nb-ldap-2dadmin1-0) | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| [Documentation] Basic suite setup | ||
| Set Library Search Order SeleniumLibrary | ||
| RHOSi Setup | ||
| # Prepare a namespace for storing values that should be shared between different upgrade test phases | ||
| # 1. if the namespace exists already, let's remove it | ||
| ${return_code} ${cmd_output} = Run And Return Rc And Output |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| # robocop:disable | ||
| [Documentation] Verify Notebook pod has not restarted after the upgrade | ||
| [Tags] Upgrade | ||
| ${notebook_name}= Get User CR Notebook Name ${TEST_USER2.USERNAME} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| [Documentation] Verify Notebook pod has not restarted after the upgrade | ||
| [Tags] Upgrade | ||
| ${notebook_name}= Get User CR Notebook Name ${TEST_USER2.USERNAME} | ||
| ${notebook_pod_name}= Get User Notebook Pod Name ${TEST_USER2.USERNAME} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
jstourac
added
verified
jstourac
merged commit 930e0e9
into
red-hat-data-services:master
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiridanek, jstourac, kobihk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This refactores this test - the first test part is moved to "pre_upgrade" phase, because this phase is run on the pre-upgrade version with the pre-upgrade code-base (branch). This is crucial since the further phases will be run with the code-base of the upgraded product and we may hit some issues in the differences in the product otherwise.
There are done other changes and fixes to the test to make it more robust including the notebook deletion in the post upgrade phase.
Apart from that, to propagate the timestamp value between the phases, this introduces a configmap in the "upgrade" namespace, where we can put some context that should be passed to the followup phase.
https://issues.redhat.com/browse/RHOAIENG-14840
At the moment I don't delete the created Config Map anywhere. We can discuss whether and when to do so eventually.
CI: tested locally on my machine with following steps:
Long Running Jupyter Notebooktest only) - using releases/2.16.0 with this backported - see [2.16][fix] the Verify Notebook Has Not Restarted upgrade test #2174Verify Notebook Has Not Restartedtest only) - using this branch which is based on masterJenkins runs: