Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword to find cluster type based on cluster infrastructure #2154

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add keyword to find cluster type based on cluster infrastructure #2154

merged 1 commit into from
Jan 7, 2025

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa commented Jan 3, 2025 •
edited
Loading

This PR

  • Removes keyword "Is Cluster Type Self-Managed" as it was suggested not to rely on console url to find cluster type
  • In all self-managed clusters, there is no common key in "oc get infrastructure cluster" output which can be used to
    identify the cluster-type
  • There is one common key in all managed clusters which i found useful to identify the cluster-type 
    {
                     "key": "red-hat-managed",
                     "value": "true"
                 }


- Adds a keyword "Is Cluster Type Managed" to find the cluster type based on cluster infrastructure

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 3, 2025
View reviewed changes
ods_ci/tests/Resources/OCP.resource
... Returns ${TRUE} if cluster type is Managed
... Returns ${FALSE} if cluster type is Self-Managed
${rc} ${output}= Run And Return Rc And Output
... oc get infrastructure cluster -o jsonpath='{.status.platformStatus.*.resourceTags[?(@.key=="red-hat-managed")].value}'

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (129/120)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
589 0 0 589 100

@jgarciao jgarciao self-requested a review January 7, 2025 09:30
@jgarciao jgarciao merged commit 1157066 into red-hat-data-services:master Jan 7, 2025
11 checks passed
@ChughShilpa ChughShilpa deleted the managed branch January 7, 2025 10:11
lenahorsley pushed a commit to lenahorsley/ods-ci that referenced this pull request Jan 17, 2025
@ChughShilpa
Add keyword to find cluster type based on cluster infrastructure (red…
af04b24 
…-hat-data-services#2154)

Add keyword to find cluster type based on infrastructure
@ChughShilpa ChughShilpa restored the managed branch February 18, 2025 07:27
@ChughShilpa ChughShilpa deleted the managed branch February 18, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarciao jgarciao jgarciao approved these changes

@sutaakar sutaakar sutaakar approved these changes

@jiripetrlik jiripetrlik Awaiting requested review from jiripetrlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChughShilpa @jgarciao @sutaakar