Smoke Test failure - Name fix for Runtime template #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ods_ci/tests/Tests/1000__model_serving/1003__model_serving_customruntimes.robot
Fixed
Show fixed
Hide fixed
ods_ci/tests/Tests/1000__model_serving/1003__model_serving_customruntimes.robot
Fixed
Show fixed
Hide fixed
Robot Results
|
ConorOM1
previously approved these changes
Dec 2, 2024
tarukumar
reviewed
Dec 3, 2024
| @@ -5,14 +5,15 @@ Resource ../../Resources/Page/ODH/ODHDashboard/ODHDashboardSettingsRunt | |||
| Resource ../../Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource | |||
| Resource ../../Resources/Page/ODH/ODHDashboard/ODHModelServing.resource | |||
| Suite Setup Custom Serving Runtime Suite Setup | |||
| Suite Teardown Custom Serving Runtime Suite Teardown | |||
| #Suite Teardown Custom Serving Runtime Suite Teardown | |||
There was a problem hiding this comment.
Why teardown is commented ?
There was a problem hiding this comment.
I forgot to uncomment it , let me uncomment it now
ConorOM1
previously approved these changes
Dec 3, 2024
tarukumar
reviewed
Dec 3, 2024
| @@ -25,7 +26,7 @@ Verify RHODS Admins Can Import A Custom Serving Runtime Template By Uploading A | |||
| Open Dashboard Settings settings_page=Serving runtimes | |||
| Upload Serving Runtime Template runtime_filepath=${OVMS_RUNTIME_FILEPATH} | |||
| ... serving_platform=multi runtime_protocol=gRPC | |||
| Serving Runtime Template Should Be Listed displayed_name=${UPLOADED_OVMS_DISPLAYED_NAME} | |||
| Serving Runtime Template Should Be Listed displayed_name=${UPLOADED_OVMS_XPATH_NAME} | |||
There was a problem hiding this comment.
Where is the displayed_name=${UPLOADED_OVMS_XPATH_NAME varible name i f9 not see in the suite
tarukumar
approved these changes
Dec 3, 2024
|
ConorOM1
approved these changes
Dec 3, 2024
Raghul-M
added a commit
to Raghul-M/ods-ci
that referenced
this pull request
Dec 10, 2024
…ices#2103) * Name fix for Runtime template * Name fix for Runtime YAML template * uncommented teardown --------- Co-authored-by: Tarun Kumar <takumar@redhat.com>
kobihk
added a commit
that referenced
this pull request
Dec 10, 2024
lenahorsley
pushed a commit
to lenahorsley/ods-ci
that referenced
this pull request
Jan 17, 2025
…ices#2103) * Name fix for Runtime template * Name fix for Runtime YAML template * uncommented teardown --------- Co-authored-by: Tarun Kumar <takumar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.