Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Check Application Switcher Links for OCM #2033

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

manosnoam
Copy link
Contributor

Fix the test in 0401__ods_dashboard.robot: Check Application Switcher Links To Openshift Cluster Manager
that stopped working on Managed Cluster (when verifying the cluster in OCM).

image

Fix the test and keywords in 0401__ods_dashboard.robot:
`Check Application Switcher Link To Openshift Cluster Manager`
that stopped working on Managed Cluster when verifying cluster in OCM.

Signed-off-by: manosnoam <nmanos@redhat.com>
[Documentation] Checks the HTTP status of OpenShift Console
${list_of_links}= Get Links From Switcher
${status}= Check HTTP Status Code link_to_check=${list_of_links}[0] verify_ssl=${False}
Should Be Equal ${list_of_links}[0] ${OCP_CONSOLE_URL}/
Should Be Equal ${status} ${200}

Check Application Switcher Link To Openshift Cluster Manager

Check warning

Code scanning / Robocop

Keyword '{{ keyword_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Keyword 'Check Application Switcher Link To Openshift Cluster Manager' has too many keywords inside (13/10)
[Documentation] Checks the HTTP status of OpenShift Console
${list_of_links}= Get Links From Switcher
${status}= Check HTTP Status Code link_to_check=${list_of_links}[0] verify_ssl=${False}
Should Be Equal ${list_of_links}[0] ${OCP_CONSOLE_URL}/
Should Be Equal ${status} ${200}

Check Application Switcher Link To Openshift Cluster Manager
[Documentation] Checks for HTTP status of OCM link and verify the Cluster in OCM
${ocm_link}= Get Element Attribute xpath://a[contains(.,"OpenShift Cluster Manager")] href

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
Login To OCM
Reload Page
Wait Until OCM Cluster Page Is Loaded ${cluster_id}
END

Check warning

Code scanning / Robocop

File has too many lines ({{ lines_count }}/{{max_allowed_count }}) Warning test

File has too many lines (615/400)
@manosnoam manosnoam added the verified This PR has been tested with Jenkins label Nov 14, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
566 0 0 566 100

@manosnoam manosnoam merged commit b5db152 into red-hat-data-services:master Nov 18, 2024
8 checks passed
lenahorsley pushed a commit to lenahorsley/ods-ci that referenced this pull request Nov 18, 2024
…vices#2033)

Fix Test `Check Application Switcher Links`

Fix the test and keywords in 0401__ods_dashboard.robot:
`Check Application Switcher Link To Openshift Cluster Manager`
that stopped working on Managed Cluster when verifying cluster in OCM.

Signed-off-by: manosnoam <nmanos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants