Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre/post upgrade test for Model Registry #1970

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Add pre/post upgrade test for Model Registry #1970

merged 6 commits into from
Oct 28, 2024

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Oct 25, 2024

No description provided.

@lugi0
Add pre/post upgrade test for Model Registry
8a75176 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0 lugi0 added verified This PR has been tested with Jenkins new test New test(s) added (PR will be listed in release-notes) enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Oct 25, 2024
@lugi0 lugi0 self-assigned this Oct 25, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
556 0 0 556 100

tonyxrmdavidson
tonyxrmdavidson reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@tonyxrmdavidson tonyxrmdavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principal. Would be good to see it run through the pr-check job.

@lugi0 lugi0 mentioned this pull request Oct 25, 2024
Merged
@lugi0
disable component after test execution
dc29d33 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
add comment
a5adaf9 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 25, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ModelRegistry/ModelRegistry.resource
@@ -0,0 +1,402 @@
# robocop: off=too-many-calls-in-keyword, mixed-tabs-and-spaces, line-too-long, file-too-long

Check warning

Code scanning / Robocop

Inconsistent use of tabs and spaces in file Warning test

Inconsistent use of tabs and spaces in file
ods_ci/tests/Resources/Page/ModelRegistry/ModelRegistry.resource
... xpath:${MR_VERSION_TABLE_XPATH}/tbody/tr/td[@data-label="Author" and .="${MR_REGISTERED_MODEL_AUTHOR}"]
SeleniumLibrary.Close All Browsers
# TODO: Update after component goes GA and is enabled by default
Set Suite Variable ${DISABLE_COMPONENT} ${True}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
ods_ci/tests/Resources/Page/ModelRegistry/ModelRegistry.resource
Remove Deployment Files ${CERTS_DIRECTORY}
Remove Deployment Files ${MODELREGISTRY_BASE_FOLDER}/Python_Dependencies
Disable Model Registry If Needed
RHOSi Teardown

Check warning

Code scanning / Robocop

File has too many lines ({{ lines_count }}/{{max_allowed_count }}) Warning test

File has too many lines (406/400)
lugi0 added 2 commits October 25, 2024 16:57
@lugi0
add teardown step to post upgrade scenario
096b32a 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
Add sleep before opening workbench
982a008 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lugi0
Copy link
Contributor Author

lugi0 commented Oct 25, 2024

Tested in rhods-ci-pr-test/3412 and passing (without upgrade in between, but doesn't really matter - upgrade has been tested manually)

@lugi0 lugi0 enabled auto-merge (squash) October 25, 2024 15:44
tonyxrmdavidson
tonyxrmdavidson approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@tonyxrmdavidson tonyxrmdavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lugi0 lugi0 merged commit a5cf4f8 into red-hat-data-services:master Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyxrmdavidson tonyxrmdavidson tonyxrmdavidson approved these changes

@bdattoma bdattoma bdattoma approved these changes

@nehachopra27 nehachopra27 Awaiting requested review from nehachopra27

Assignees

@lugi0 lugi0

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lugi0 @tonyxrmdavidson @bdattoma