Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Dashboard UI tests #1922

Merged
merged 9 commits into from
Oct 13, 2024
Merged

Fix: Dashboard UI tests #1922

merged 9 commits into from
Oct 13, 2024

Conversation

FedeAlonso
Copy link
Contributor

@FedeAlonso FedeAlonso commented Oct 11, 2024 •
edited
Loading

Failed tests from job/cypress/job/dashboard-tests/33:

  • ODS-1813: Verify Users Can Start, Stop, Launch And Delete A Workbench
  • ODS-1818: Verify Users Can Start, Stop And Launch A Workbench From DS Projects Home Page
  • ODS-2276: Verify RHODS Admins Can Import A Custom Serving Runtime Template By Uploading A YAML file

AFTER THE FIX:
image

@FedeAlonso FedeAlonso requested a review from manosnoam October 11, 2024 12:15
@FedeAlonso FedeAlonso added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
545 0 0 545 100

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FedeAlonso FedeAlonso marked this pull request as ready for review October 11, 2024 23:14
manosnoam
manosnoam approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fede!

@jstourac
Copy link
Member

I can see that the job that is referenced was run against the RHOAI 2.14rc1, thus is applicable for our current master branch. As such, I'm gonna merge this one rightaway to see the results from the nearest nightly job triggered.

@jstourac jstourac merged commit dc6e870 into red-hat-data-services:master Oct 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manosnoam manosnoam manosnoam approved these changes

@jstourac jstourac jstourac approved these changes

@antowaddle antowaddle Awaiting requested review from antowaddle

@ConorOM1 ConorOM1 Awaiting requested review from ConorOM1

@jgarciao jgarciao Awaiting requested review from jgarciao

@asanzgom asanzgom Awaiting requested review from asanzgom

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedeAlonso @jstourac @manosnoam