[Fix] the tests for custom image import #1920
Conversation
jstourac
added
the
enhancements
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Robot Results
|
jstourac
force-pushed
the
fixImageDuplicate
branch
from
14ba5a2 to
758d176
Compare
This fixes multiple tests in the custom image import and fixes some common keywords from the ODHDashboard.robot file.
jstourac
force-pushed
the
fixImageDuplicate
branch
from
758d176 to
ef24e66
Compare
|
| # Wait for the image to disappear from the list | ||
| Wait Until Page Does Not Contain Element xpath:${custom_image_kebab_btn} timeout=10s | ||
| # Assure that the actual ImageStream is also removed | ||
| ${rc} ${out}= Run And Return Rc And Output |
Check notice
Code scanning / Robocop
Variable '{{ name }}' is assigned but not used Note test
| Wait Until Page Contains Unable to add notebook image: HTTP request failed | ||
| Log Unable to add second image with error message "Unable to add notebook image: HTTP request failed" due to RHOAIENG-1192 level=WARN # robocop: disable | ||
| # Assure that the expected error message is shown in the modal window | ||
| ${image_name_id}= Replace String ${IMG_NAME} ${SPACE} - |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
| Log Unable to add second image with error message "Unable to add notebook image: HTTP request failed" due to RHOAIENG-1192 level=WARN # robocop: disable | ||
| # Assure that the expected error message is shown in the modal window | ||
| ${image_name_id}= Replace String ${IMG_NAME} ${SPACE} - | ||
| Wait Until Page Contains Unable to add notebook image: imagestreams.image.openshift.io "custom-${image_name_id}" already exists |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
jstourac
changed the title
| [Tags] Tier1 | ||
| ... ODS-2470 | ||
| ... ExcludeOnDisconnected # Since we don't have internal image registry enabled there usually | ||
| ... InternalImageRegistry # Requires internal image registry enabled | ||
| ... ProductBug # https://issues.redhat.com/browse/RHOAIENG-1193 |
There was a problem hiding this comment.
If the test has ProductBug, it will be run only in the known-issues quality gate. Beware RHOAIENG-1193 is closed as "Won't Do"
There was a problem hiding this comment.
Yeah, TBH, I was wondering whether we shouldn't remove the test at all... will consider it and maybe raise a separate issue.
| [Tags] Tier1 | ||
| ... ODS-2470 | ||
| ... ExcludeOnDisconnected # Since we don't have internal image registry enabled there usually |
There was a problem hiding this comment.
Hi @jstourac this is the matter of an option in our automation where the internal registry is disabled default. Moreover, the internal image registry can be enabled/disabled outside of disconnected automation (using oc command).
There was a problem hiding this comment.
I know, Andrej. But the test isn't passing now anyway. Also, since the linked issue won't be fixed probably, the test will probably go away at all.
You are right, Luca - I was considering it for the |
https://issues.redhat.com/browse/RHOAIENG-1192 has been resolved, so we can update that test accordingly.
Plust this fixes another one test in the custom image import and fixes some common keywords from the ODHDashboard.robot file.
CI: