Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the workbench start for the Jupyter 4 (images 2024.2) #1899

Merged

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Oct 8, 2024

This is a followup of #1870.


Quick CI (actually no Jupyter lab code executed):

image

@jstourac jstourac added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Oct 8, 2024
@jstourac jstourac self-assigned this Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
547 0 0 547 100

@jstourac jstourac force-pushed the fixWorkbenchStart2024b branch from baf51f0 to 8e79504 Compare October 8, 2024 12:40
Copy link

sonarqubecloud bot commented Oct 8, 2024

@jstourac jstourac added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Oct 8, 2024
@jstourac jstourac enabled auto-merge (rebase) October 8, 2024 13:46
@jstourac jstourac merged commit b8ee83d into red-hat-data-services:master Oct 8, 2024
8 checks passed
@jstourac jstourac deleted the fixWorkbenchStart2024b branch October 8, 2024 13:49
jstourac added a commit to jstourac/ods-ci that referenced this pull request Oct 9, 2024
…using the library keyword

After the fix red-hat-data-services#1899 this change isn't necessary so let's use the
standard way how JupyterLibrary does this so we are in sync there.
jstourac added a commit that referenced this pull request Oct 9, 2024
…word

After the fix #1899 this change isn't necessary so let's use the
standard way how JupyterLibrary does this so we are in sync there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants