Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Model Registry test in Smoke #1883

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Enable Model Registry test in Smoke #1883

merged 10 commits into from
Oct 2, 2024

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Oct 2, 2024

No description provided.

lugi0 added 2 commits October 2, 2024 16:42
@lugi0
Enable component if needed
625811a 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
update tags
e65a75a 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0 lugi0 added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Oct 2, 2024
@lugi0 lugi0 requested a review from tonyxrmdavidson October 2, 2024 14:44
@lugi0 lugi0 self-assigned this Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
547 0 0 547 100

@lugi0
wait for namespace to become active after enabling component
48c67f6 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0 lugi0 requested a review from nehachopra27 October 2, 2024 14:59
lugi0 added 5 commits October 2, 2024 17:00
@lugi0
Remove sleep after code execution in Jupyter
9c03d9c 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
Upload files after accessing the workbench rather than before
1f73cbb 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
Ensure namespace exists before waiting
69d626c 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
change if condition
db54663 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
refresh dashboard if model registry not present
cc35c5e 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
change while loop behaviour
be24676 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0
add small sleep in jupyter
048a252 
Signed-off-by: lugi0 <lgiorgi@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lugi0
Copy link
Contributor Author

lugi0 commented Oct 2, 2024

verified in rhoai-test-flow/665

@lugi0 lugi0 added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Oct 2, 2024
tonyxrmdavidson
tonyxrmdavidson approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@tonyxrmdavidson tonyxrmdavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

CFSNM
CFSNM approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@CFSNM CFSNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lugi0 great having the keywords to enable/disable the component if needed

MarianMacik
MarianMacik approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MarianMacik MarianMacik merged commit 954b86c into red-hat-data-services:master Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarianMacik MarianMacik MarianMacik approved these changes

@tonyxrmdavidson tonyxrmdavidson tonyxrmdavidson approved these changes

@CFSNM CFSNM CFSNM approved these changes

@nehachopra27 nehachopra27 Awaiting requested review from nehachopra27

Assignees

@lugi0 lugi0

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lugi0 @MarianMacik @tonyxrmdavidson @CFSNM