Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to provide runtime image dynamically for vllm #1863

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

tarukumar
Copy link
Contributor

No description provided.

Signed-off-by: Tarun Kumar <takumar@redhat.com>
Copy link

${rc} ${out}= Run And Return Rc And Output
... oc apply -f ${runtime_final_filepath} -n ${namespace}
Should Be Equal As Integers ${rc} ${0}

Set Project And Runtime
[Documentation] Creates the DS Project (if not exists), creates the data connection for the models,
... creates caikit runtime. This can be used as test setup
[Arguments] ${namespace} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime ${protocol}=grpc
... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY}
[Arguments] ${namespace} ${runtime_image} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime

Check notice

Code scanning / Robocop

There is too many arguments per continuation line ({{ arguments_count }} / {{ max_arguments_count }}) Note test

There is too many arguments per continuation line (4 / 1)
${rc} ${out}= Run And Return Rc And Output
... oc apply -f ${runtime_final_filepath} -n ${namespace}
Should Be Equal As Integers ${rc} ${0}

Set Project And Runtime
[Documentation] Creates the DS Project (if not exists), creates the data connection for the models,
... creates caikit runtime. This can be used as test setup
[Arguments] ${namespace} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime ${protocol}=grpc
... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY}
[Arguments] ${namespace} ${runtime_image} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime

Check warning

Code scanning / Robocop

Keyword argument '{{ name }}' is not used Warning test

Keyword argument '${runtime_image}' is not used
[Arguments] ${namespace} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime ${protocol}=grpc
... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY}
[Arguments] ${namespace} ${runtime_image} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime
... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY} ${protocol}=grpc

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (123/120)
[Arguments] ${namespace} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime ${protocol}=grpc
... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY}
[Arguments] ${namespace} ${runtime_image} ${enable_metrics}=${FALSE} ${runtime}=caikit-tgis-runtime
... ${access_key_id}=${S3.AWS_ACCESS_KEY_ID} ${access_key}=${S3.AWS_SECRET_ACCESS_KEY} ${protocol}=grpc

Check notice

Code scanning / Robocop

There is too many arguments per continuation line ({{ arguments_count }} / {{ max_arguments_count }}) Note test

There is too many arguments per continuation line (3 / 1)
@tarukumar tarukumar merged commit 4fccb8e into red-hat-data-services:master Sep 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants