Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tensorflow model REST protocol test on triton for Modelmesh #1840

Merged
merged 22 commits into from
Oct 24, 2024
Merged

Added Tensorflow model REST protocol test on triton for Modelmesh #1840

merged 22 commits into from
Oct 24, 2024

Conversation

Raghul-M
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2024
View reviewed changes
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
Comment on lines +117 to +118

Test Tensorflow Model Rest Inference Via UI (Triton on Modelmesh)

Check warning

Code scanning / Robocop

Invalid number of empty lines between test cases ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between test cases (2/1)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
@@ -110,6 +114,47 @@
... AND
... Delete Serving Runtime Template From CLI displayed_name=modelmesh-triton


Test Tensorflow Model Rest Inference Via UI (Triton on Modelmesh)

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test

Test case 'Test Tensorflow Model Rest Inference Via UI (Triton on Modelmesh)' is too long (33/20)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
@@ -110,6 +114,47 @@
... AND
... Delete Serving Runtime Template From CLI displayed_name=modelmesh-triton


Test Tensorflow Model Rest Inference Via UI (Triton on Modelmesh)

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Test Tensorflow Model Rest Inference Via UI (Triton on Modelmesh)' has too many keywords inside (14/10)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
Recreate S3 Data Connection project_title=${PRJ_TITLE} dc_name=model-serving-connection
... aws_access_key=${S3.AWS_ACCESS_KEY_ID} aws_secret_access=${S3.AWS_SECRET_ACCESS_KEY}
... aws_bucket_name=ods-ci-s3
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${TRUE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (135/120)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
Wait Until Runtime Pod Is Running server_name=${ONNX_RUNTIME_NAME}
... project_title=${PRJ_TITLE} timeout=5m
Verify Model Status ${TENSORFLOW_MODEL_NAME} success
${EXPECTED_INFERENCE_REST_OUTPUT_TENSORFLOW}= Load Json File file_path=${EXPECTED_INFERENCE_TENSORFLOW_OUTPUT_FILE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (128/120)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
546 0 0 546 100

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 23, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
@@ -121,7 +121,7 @@
... Selects the given one
[Arguments] ${model_server}
${selectable}= Run Keyword And Return Status
... Wait Until Element Is Visible xpath://span[.="Model servers"]/../../..//button[@aria-label="Options menu"] timeout=1
... Wait Until Element Is Visible xpath://span[.="Model servers"]/../../..//button[@aria-label="Options menu"] timeout=3

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (133/120)
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 23, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource
@@ -228,7 +229,7 @@
[Documentation] Gets the (Single Model) Token of an specific Service Account
[Arguments] ${service_account_name}
${token}= Get Element Attribute
... xpath://div[text()='${service_account_name}']/parent::td[@data-label='Token Name']/following-sibling::td[@data-label='Token Secret']//input value
... xpath://div[text()='${service_account_name}']/parent::td[@data-label='Token Name']/following-sibling::td[@data-label='Token Secret']//input value

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (158/120)
bdattoma
bdattoma reviewed Sep 23, 2024
View reviewed changes
ods_ci/tests/Resources/Files/triton/triton_tensorflow_modelmesh_runtime.yaml
@@ -0,0 +1,73 @@
apiVersion: serving.kserve.io/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same as https://github.com/red-hat-data-services/ods-ci/pull/1835/files
Can you avoid duplication and use one single runtime definition for multiple models?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raghul-M you marked this as resolved, how this was resolved?

bdattoma
bdattoma reviewed Sep 23, 2024
View reviewed changes
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot Outdated
@@ -13,7 +13,7 @@ Resource ../../../Resources/OCP.resource
Resource ../../../Resources/CLI/ModelServing/modelmesh.resource
Resource ../../../Resources/Common.robot
Suite Setup Triton On Kserve Suite Setup
Suite Teardown Triton On Kserve Suite Teardown
#Suite Teardown Triton On Kserve Suite Teardown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disabling teardown? is it temporary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its temporary commented for some investigation i will uncomment in the final commit

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 26, 2024
View reviewed changes
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
... Clean All Models Of Current User



Check warning

Code scanning / Robocop

Invalid number of empty lines between sections ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between sections (1/2)
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Raghul-M
Copy link
Contributor Author

Raghul-M commented Oct 1, 2024

Verified with Jenkins Build 621

@Raghul-M Raghul-M added verified This PR has been tested with Jenkins new test New test(s) added (PR will be listed in release-notes) labels Oct 1, 2024
jiridanek
jiridanek approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the way files are not-shared between multiple PRs, but I'm not strictly opposed. Just don't forget to tidy it all up!

@jstourac jstourac merged commit 8ec85c4 into red-hat-data-services:master Oct 24, 2024
8 checks passed
tonyxrmdavidson pushed a commit to tonyxrmdavidson/ods-ci that referenced this pull request Oct 25, 2024
@Raghul-M @tonyxrmdavidson
Added Tensorflow model REST protocol test on triton for Modelmesh (re…
de3bd47 
…d-hat-data-services#1840)

* added modelmesh tensorflow testcase

* changed filepath

* changed

* changed output file

* increased timeout

* uncommented

* new xpath

* new xpath

* new xpath

* new xpath span

* new KW added

* Log added

* Log added

* added service_accountname

* added service_accountname

* added service_accountname1

* uncommented

* changes

* input changed

* removed Log and uncommented teardown

* changed timeout

* removed RunThisTest tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiridanek jiridanek jiridanek approved these changes

@lugi0 lugi0 lugi0 approved these changes

@tarukumar tarukumar tarukumar approved these changes

@bdattoma bdattoma Awaiting requested review from bdattoma

@rpancham rpancham Awaiting requested review from rpancham

Assignees
No one assigned
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Raghul-M @jiridanek @lugi0 @bdattoma @tarukumar @jstourac