Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button xpath to work with latest ODH #1837

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Sep 20, 2024

No description provided.

Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0 lugi0 added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Sep 20, 2024
@lugi0 lugi0 self-assigned this Sep 20, 2024
jstourac
jstourac previously approved these changes Sep 20, 2024
CFSNM
CFSNM previously approved these changes Sep 20, 2024
@jstourac
Copy link
Member

Optionally we could put some comment that the latter value should be required once the odh code is pulled downstream.

Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0 lugi0 dismissed stale reviews from CFSNM and jstourac via 02fd543 September 20, 2024 14:29
@lugi0 lugi0 requested review from jstourac and CFSNM September 20, 2024 14:29
@lugi0
Copy link
Contributor Author

lugi0 commented Sep 20, 2024

@jstourac done

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
541 0 0 541 100

Copy link

@lugi0 lugi0 merged commit 7a1f2d0 into red-hat-data-services:master Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants