Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-13014 - Rewrite Verify RHODS Operator Logs test #1822

Merged
merged 1 commit into from
Sep 20, 2024
Merged

RHOAIENG-13014 - Rewrite Verify RHODS Operator Logs test #1822

merged 1 commit into from
Sep 20, 2024

Conversation

MarianMacik
Copy link
Contributor

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
541 0 0 541 100

CFSNM
CFSNM previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@CFSNM CFSNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @MarianMacik lets backport this change to the 2.13 branch

@MarianMacik MarianMacik mentioned this pull request Sep 18, 2024
Merged
@mattmahoneyrh
Copy link
Contributor

Given that there are no Labels set, has this been tested via Jenkins RHOAI job?

@MarianMacik MarianMacik added the verified This PR has been tested with Jenkins label Sep 19, 2024
@MarianMacik
Copy link
Contributor Author

@mattmahoneyrh Yes, it was tested, see job/rhoai/job/2.13/job/selfmanaged/job/cli/job/aws/job/rhoai-tier3/ for last few runs. All of them passed with this test.

mattmahoneyrh
mattmahoneyrh previously approved these changes Sep 19, 2024
View reviewed changes
@mattmahoneyrh
Copy link
Contributor

Approved... but there are conflicts that will need to be resolved prior to merge.

@MarianMacik MarianMacik dismissed stale reviews from mattmahoneyrh and CFSNM via 4698fad September 19, 2024 15:17
@mattmahoneyrh mattmahoneyrh self-requested a review September 19, 2024 15:24
mattmahoneyrh
mattmahoneyrh previously approved these changes Sep 19, 2024
View reviewed changes
mattmahoneyrh added a commit that referenced this pull request Sep 19, 2024
@mattmahoneyrh
[2.13.0] RHOAIENG-13014 - Rewrite Verify RHODS Operator Logs test (#1824
074c999 
)

**JIRA:**
[RHOAIENG-13014](https://issues.redhat.com/browse/RHOAIENG-13014)

backport of #1822
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarianMacik MarianMacik merged commit 649f2b2 into red-hat-data-services:master Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmahoneyrh mattmahoneyrh mattmahoneyrh approved these changes

@CFSNM CFSNM CFSNM approved these changes

@asanzgom asanzgom asanzgom approved these changes

Assignees
No one assigned
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarianMacik @mattmahoneyrh @CFSNM @asanzgom