Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added onnx model Modelmesh test on triton #1777

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Added onnx model Modelmesh test on triton #1777

merged 13 commits into from
Sep 9, 2024

Conversation

Raghul-M
Copy link
Contributor

@Raghul-M Raghul-M commented Sep 4, 2024

Added Automation Test for RHOAIENG-11566

@Raghul-M Raghul-M added needs testing Needs to be tested in Jenkins do not merge Do not merge this yet please labels Sep 4, 2024
@Raghul-M Raghul-M self-assigned this Sep 4, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 4, 2024
View reviewed changes
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
${PRJ_DESCRIPTION}= project used for model serving triton runtime tests
${MODEL_CREATED}= ${FALSE}
${ONNX_MODEL_NAME}= densenet_onnx
${ONNX_MODEL_LABEL}= densenetonnx

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${ONNX_MODEL_LABEL}' is assigned but not used
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
#... project_title=${PRJ_TITLE}
#... AND
#... Clean All Models Of Current User

Check warning

Code scanning / Robocop

Invalid number of empty lines between sections ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between sections (1/2)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
IF ${MODEL_CREATED}
Clean All Models Of Current User
ELSE
Log Model not deployed, skipping deletion step during teardown console=true

Check warning

Code scanning / Robocop

{{ bad_indent_msg }} Warning test

Line is under-indented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too pity of this one

...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
ELSE
Log Model not deployed, skipping deletion step during teardown console=true
END
${projects}= Create List ${PRJ_TITLE}

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create List can be replaced with VAR
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
535 0 0 535 100

@Raghul-M Raghul-M added verified This PR has been tested with Jenkins new test New test(s) added (PR will be listed in release-notes) and removed needs testing Needs to be tested in Jenkins do not merge Do not merge this yet please labels Sep 9, 2024
@Raghul-M
Copy link
Contributor Author

Raghul-M commented Sep 9, 2024

Verified success with Jenkins Build 164

@Raghul-M Raghul-M requested a review from bdattoma September 9, 2024 13:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jstourac jstourac merged commit 5b9d1c8 into red-hat-data-services:master Sep 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac left review comments

@CFSNM CFSNM CFSNM approved these changes

@bdattoma bdattoma bdattoma approved these changes

@tarukumar tarukumar Awaiting requested review from tarukumar

Assignees

@Raghul-M Raghul-M

Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raghul-M @jstourac @CFSNM @bdattoma