reworking platform tests tagging following the 1-tag approach #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFSNM
requested review from
jgarciao,
mattmahoneyrh,
manosnoam,
jstourac,
FedeAlonso,
bdattoma,
tarukumar and
asanzgom
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...01__deploy/0104__operators/0104__rhods_operator/0108__rhods_operator_logs_verification.robot
Fixed
Show fixed
Hide fixed
Robot Results
|
CFSNM
force-pushed
the
platform_tests_tagging
branch
4 times, most recently
from
721b8e3 to
708c5f7
Compare
...01__deploy/0104__operators/0104__rhods_operator/0108__rhods_operator_logs_verification.robot
Dismissed
Show dismissed
Hide dismissed
...01__deploy/0104__operators/0104__rhods_operator/0108__rhods_operator_logs_verification.robot
Dismissed
Show dismissed
Hide dismissed
CFSNM
force-pushed
the
platform_tests_tagging
branch
from
708c5f7 to
e55c19c
Compare
jgarciao
previously approved these changes
Sep 2, 2024
bdattoma
previously approved these changes
Sep 2, 2024
CFSNM
force-pushed
the
platform_tests_tagging
branch
from
e55c19c to
cdc8ccd
Compare
| @@ -144,6 +141,8 @@ | |||
| Operator Setup | |||
| [Documentation] Setup for the Operator tests | |||
| RHOSi Setup | |||
| ${IS_SELF_MANAGED}= Is RHODS Self-Managed | |||
| Set Suite Variable ${IS_SELF_MANAGED} | |||
Check notice
Code scanning / Robocop
{{ set_variable_keyword }} can be replaced with VAR Note test
bdattoma
previously approved these changes
Sep 3, 2024
CFSNM
force-pushed
the
platform_tests_tagging
branch
from
78ad7aa to
19e09b1
Compare
CFSNM
force-pushed
the
platform_tests_tagging
branch
2 times, most recently
from
c40f211 to
fd5193b
Compare
bdattoma
previously approved these changes
Sep 3, 2024
CFSNM
force-pushed
the
platform_tests_tagging
branch
from
392e51d to
f6782bd
Compare
CFSNM
force-pushed
the
platform_tests_tagging
branch
2 times, most recently
from
63d4dba to
e3a21f2
Compare
asanzgom
previously approved these changes
Sep 3, 2024
MarianMacik
reviewed
Sep 3, 2024
...01__deploy/0104__operators/0104__rhods_operator/0108__rhods_operator_logs_verification.robot
Show resolved
Hide resolved
...01__deploy/0104__operators/0104__rhods_operator/0108__rhods_operator_logs_verification.robot
Outdated
Show resolved
Hide resolved
CFSNM
force-pushed
the
platform_tests_tagging
branch
from
e3a21f2 to
ee96898
Compare
| #To check if command has been suessfully executed and the logs has been captured | ||
| IF len($val)==${0} or "error:" in $val FAIL Either OC command has not been executed sucessfully or Logs is not present | ||
| ${val} Run oc logs --tail=1000000 ${data[0]['metadata']['name']} -n ${OPERATOR_NAMESPACE} -c ${OPERATOR_POD_CONTAINER_NAME} | ||
| #To check if command has been successfully executed and the logs have been captured |
Check warning
Code scanning / Robocop
Missing blank space after comment character Warning test
| IF len($val)==${0} or "error:" in $val FAIL Either OC command has not been executed sucessfully or Logs is not present | ||
| ${val} Run oc logs --tail=1000000 ${data[0]['metadata']['name']} -n ${OPERATOR_NAMESPACE} -c ${OPERATOR_POD_CONTAINER_NAME} | ||
| #To check if command has been successfully executed and the logs have been captured | ||
| IF len($val)==${0} or "error:" in $val FAIL Either OC command has not been executed successfully or Logs are not present |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
CFSNM
force-pushed
the
platform_tests_tagging
branch
from
ee96898 to
0739612
Compare
|
MarianMacik
approved these changes
Sep 3, 2024
asanzgom
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://issues.redhat.com/browse/RHOAIENG-11797