Fix "SKIPPED" status in Post upgrade suite #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
Dismissed
Show dismissed
Hide dismissed
ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
Dismissed
Show dismissed
Hide dismissed
bdattoma
added
needs testing
Robot Results
|
|
ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
Dismissed
Show dismissed
Hide dismissed
bdattoma
changed the title
CFSNM
approved these changes
Aug 21, 2024
|
Waiting for rhods-ci-pr-test/3270/ to finish successfully to approve |
asanzgom
approved these changes
Aug 21, 2024
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Sep 1, 2024
* replace SKIP with IF * add missing documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some tests in post upgrade suite have "SKIPPED" status because a piece of the teardown gets skipped if RHOAI operator is not Managed.
This PR replaces the call to SKIP keyword with IF statement so to avoid the SKIPPED status which doesn't reflect the right test status
PR validation:
rhods-ci-pr-test/3270OK - 1 failure expected for automation issue