-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-7919 Istio Kserve Gateway For Internal Endpoint #1583
RHOAIENG-7919 Istio Kserve Gateway For Internal Endpoint #1583
Conversation
Robot Results
|
Resource Should Exist Service knative-local-gateway ${ISTIO_NS} | ||
Resource Should Exist deployment controller ${KNATIVESERVING_NS} | ||
Wait For Pods Numbers 2 namespace=${KNATIVESERVING_NS} | ||
... label_selector=app.kubernetes.io/component=controller timeout=120 | ||
${pod_names}= Get Pod Names ${KNATIVESERVING_NS} app.kubernetes.io/component=controller | ||
Verify Containers Have Zero Restarts ${pod_names} ${KNATIVESERVING_NS} | ||
${podname}= Get Pod Name ${OPERATOR_NAMESPACE} ${OPERATOR_LABEL_SELECTOR} | ||
#${podname}= Get Pod Name ${OPERATOR_NAMESPACE} ${OPERATOR_LABEL_SELECTOR} |
Check warning
Code scanning / Robocop
Missing blank space after comment character Warning test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattmahoneyrh Should this be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adding istio kserve-local-gateway checks, for supports KServe Internal Endpoint.