Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-7919 Istio Kserve Gateway For Internal Endpoint #1583

Conversation

mattmahoneyrh
Copy link
Contributor

@mattmahoneyrh mattmahoneyrh commented Jul 1, 2024

Adding istio kserve-local-gateway checks, for supports KServe Internal Endpoint.

  • Use KeyWord ODS.robot.Wait For DSC Conditions Reconciled, instead of local (remove local Key Word)
  • Add DSC ready check in Suite Setup, so as to catch DSC not ready state prior to test start
  • Remove Selenium references, which are not used

@mattmahoneyrh mattmahoneyrh added the needs testing Needs to be tested in Jenkins label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
500 0 0 500 100

Resource Should Exist Service knative-local-gateway ${ISTIO_NS}
Resource Should Exist deployment controller ${KNATIVESERVING_NS}
Wait For Pods Numbers 2 namespace=${KNATIVESERVING_NS}
... label_selector=app.kubernetes.io/component=controller timeout=120
${pod_names}= Get Pod Names ${KNATIVESERVING_NS} app.kubernetes.io/component=controller
Verify Containers Have Zero Restarts ${pod_names} ${KNATIVESERVING_NS}
${podname}= Get Pod Name ${OPERATOR_NAMESPACE} ${OPERATOR_LABEL_SELECTOR}
#${podname}= Get Pod Name ${OPERATOR_NAMESPACE} ${OPERATOR_LABEL_SELECTOR}

Check warning

Code scanning / Robocop

Missing blank space after comment character Warning test

Missing blank space after comment character
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmahoneyrh Should this be updated?

@mattmahoneyrh mattmahoneyrh added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Jul 1, 2024
Copy link
Contributor

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mattmahoneyrh mattmahoneyrh merged commit 9f4dc2e into red-hat-data-services:master Jul 2, 2024
7 checks passed
@mattmahoneyrh mattmahoneyrh deleted the RHOAIENG-7919_kserve-local-gateway branch August 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants