Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Pipeline UI test in Smoke to use pip_index_url (making it compatible with disconnected clusters) #1507

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Modify Pipeline UI test in Smoke to use pip_index_url (making it compatible with disconnected clusters) #1507

merged 9 commits into from
Jun 7, 2024

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented Jun 6, 2024 •
edited
Loading

Implements RHOAIENG-3473:

  • Modifies Pipelines UI test in Smoke to use pip_index_url and pip_trusted_host. The values should be available in the global variables PIP_INDEX_URL and PIP_TRUSTED_HOST (for connected and disconnected clusters).
  • The test will:
    • Create a custom ConfigMap in the data science project containing the values for pip_index_url and pip_trusted_host
    • Run iris_pipeline_pip_index_url_compiled.yaml sample file, which reads the ConfigMap (using kfp-kubernetes, new dependency) and injects the values as env vars in the pipeline tasks.
    • Note: I had to manually modify iris_pipeline_pip_index_url_compiled.yaml in order to use PIP_TRUSTED_HOST, as currently the kfp 2.7.0 is using pip_index_url for both values
  • Tested successfully in:
    • Connected cluster: rhods/job/rhods-smoke/5720
    • Disconnected cluser: disconnect/job/psi/job/rhods-smoke/10/console

jgarciao added 3 commits June 6, 2024 18:07
@jgarciao
Add keywords to detect if cluster is disconnected
c534c37 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Add dependencty to kfp-kubernetes
acb82c1 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Modify main pipelines ui test to be compatible with disconnected
f219271 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao requested review from diegolovison and apodhrad June 6, 2024 16:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
470 0 0 470 100

@jgarciao jgarciao added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label Jun 6, 2024
@jgarciao jgarciao requested a review from HumairAK June 6, 2024 17:55
diegolovison
diegolovison previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@diegolovison diegolovison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested this PR using a notebook and manually adding the configmap.

@jgarciao jgarciao added the verified This PR has been tested with Jenkins label Jun 6, 2024
jgarciao added 3 commits June 7, 2024 12:52
@jgarciao
Speed up keyword verifying pipeline server creation
47f4590 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Refactor Pipelines UI test to always use pip_index_url
f4c3f9d 
The right values for connected/disconnected clusters will be available
as global variables PIP_INDEX_URL and PIP_TRUSTED_HOST

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao
Modify folder name for tests using pip_index_url
65a3e2e 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao added the do not merge Do not merge this yet please label Jun 7, 2024
@jgarciao jgarciao changed the title Fix UI pipeline test on disconnected cluster Modify Pipeline UI test in Smoke to use pip_index_url (making it compatible with disconnected clusters) Jun 7, 2024
@jgarciao jgarciao requested review from apodhrad and diegolovison June 7, 2024 13:29
@jgarciao
Copy link
Contributor Author

jgarciao commented Jun 7, 2024

Adding label do-not-merge until PIP_INDEX_URL and PIP_TRUSTED_HOST are configured in Jenkins

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

@jgarciao jgarciao removed the do not merge Do not merge this yet please label Jun 7, 2024
@jgarciao jgarciao merged commit 9dd70f9 into red-hat-data-services:master Jun 7, 2024
8 checks passed
jgarciao added a commit to jgarciao/ods-ci that referenced this pull request Jun 12, 2024
@jgarciao
Modify Pipeline UI test in Smoke to use pip_index_url (making it comp…
34e9649 
…atible with disconnected clusters) (red-hat-data-services#1507)

* Add keywords to detect if cluster is disconnected

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>

* Add dependencty to kfp-kubernetes

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>

* Modify main pipelines ui test to be compatible with disconnected

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>

* Speed up keyword verifying pipeline server creation

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>

* Refactor Pipelines UI test to always use pip_index_url

The right values for connected/disconnected clusters will be available
as global variables PIP_INDEX_URL and PIP_TRUSTED_HOST

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>

* Modify folder name for tests using pip_index_url

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>

* Revert "Add keywords to detect if cluster is disconnected"

This reverts commit c534c37.

---------

Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolovison diegolovison diegolovison approved these changes

@apodhrad apodhrad apodhrad approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgarciao @diegolovison @apodhrad