Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded vLLM metrics test #1500

Merged

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Jun 3, 2024

Expands the vLLM metrics test by checking that the values returned by UWM match the ones returned by the model's endpoint.
Some metrics are not checked against the le=+Inf parameter because the API query fails by returning an empty dictionary - needs further investigation

Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
@lugi0 lugi0 added new test New test(s) added (PR will be listed in release-notes) enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Jun 3, 2024
@lugi0 lugi0 requested review from mwaykole and tarukumar June 3, 2024 15:59
@lugi0 lugi0 self-assigned this Jun 3, 2024
"""
Fetch exposed metrics and their current values from a deployed vllm endpoint
"""
r = requests.get(endpoint, verify=False)

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AY_e1Fxd3p8jEPKJy4GG-->Enable server certificate validation on this SSL/TLS connection. <p>See more on <a href="https://sonarcloud.io/project/issues?id=red-hat-data-services_ods-ci&issues=AY_e1Fxd3p8jEPKJy4GG&open=AY_e1Fxd3p8jEPKJy4GG&pullRequest=1500">SonarCloud</a></p>
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
470 0 0 470 100

Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lugi0 lugi0 merged commit 8d2446d into red-hat-data-services:master Jun 7, 2024
6 of 8 checks passed
jgarciao pushed a commit to jgarciao/ods-ci that referenced this pull request Jun 12, 2024
Expand vllm metrics test

Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) new test New test(s) added (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants