-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded vLLM metrics test #1500
Merged
lugi0
merged 2 commits into
red-hat-data-services:master
from
lugi0:feature/vllm-metrics-expanded-test
Jun 7, 2024
Merged
Expanded vLLM metrics test #1500
lugi0
merged 2 commits into
red-hat-data-services:master
from
lugi0:feature/vllm-metrics-expanded-test
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
""" | ||
Fetch exposed metrics and their current values from a deployed vllm endpoint | ||
""" | ||
r = requests.get(endpoint, verify=False) |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections
<!--SONAR_ISSUE_KEY:AY_e1Fxd3p8jEPKJy4GG-->Enable server certificate validation on this SSL/TLS connection. <p>See more on <a href="https://sonarcloud.io/project/issues?id=red-hat-data-services_ods-ci&issues=AY_e1Fxd3p8jEPKJy4GG&open=AY_e1Fxd3p8jEPKJy4GG&pullRequest=1500">SonarCloud</a></p>
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
.../Tests/400__ods_dashboard/420__model_serving/LLMs/vllm/426__model_serving_vllm_metrics.robot
Dismissed
Show dismissed
Hide dismissed
Robot Results
|
tarukumar
approved these changes
Jun 5, 2024
|
mwaykole
approved these changes
Jun 7, 2024
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Jun 12, 2024
Expand vllm metrics test Signed-off-by: Luca Giorgi <lgiorgi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancements
Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
new test
New test(s) added (PR will be listed in release-notes)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the vLLM metrics test by checking that the values returned by UWM match the ones returned by the model's endpoint.
Some metrics are not checked against the
le=+Inf
parameter because the API query fails by returning an empty dictionary - needs further investigation