Finalize WIP task for fixing outstanding linter warnings #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix "F405", # `IsNotFlagged` may be undefined, or defined from star imports * Fix "UP034", # Avoid extraneous parentheses * Fix "FA100", # Missing `from __future__ import annotations`, but uses `typing.Optional` * "F841", # Local variable `response` is assigned to but never used Signed-off-by: Jiri Daněk <jdanek@redhat.com>
|
Robot Results
|
apodhrad
approved these changes
Jun 5, 2024
jiridanek
added
misc
kobihk
approved these changes
Jun 5, 2024
jgarciao
pushed a commit
to jgarciao/ods-ci
that referenced
this pull request
Jun 12, 2024
…a-services#1497) Finalize my WIP task for fixing linter warnings * Fix "F405", # IsNotFlagged may be undefined, or defined from star imports * Fix "UP034", # Avoid extraneous parentheses Signed-off-by: Jiri Daněk <jdanek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsNotFlaggedmay be undefined, or defined from star imports