Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping default retry to 150 in Wait Until Operator Subscription Last Condition Is #1470

Merged

Conversation

CFSNM
Copy link
Contributor

@CFSNM CFSNM commented May 21, 2024

The default values were 20 retry and 3 seconds of interval. There are some corner cases where this waiting time is not enough, so bumping the retries to 150, to use by default a waiting time of 450 seconds as max

@CFSNM CFSNM force-pushed the default_retry_subscription branch from f0709f3 to 7190b27 Compare May 21, 2024 10:52
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
461 0 0 461 100

@CFSNM CFSNM force-pushed the default_retry_subscription branch from 7190b27 to 4ae8fbd Compare May 21, 2024 10:57
lugi0
lugi0 previously approved these changes May 21, 2024
@CFSNM CFSNM force-pushed the default_retry_subscription branch 3 times, most recently from e8791c3 to 288085a Compare May 21, 2024 14:43
@CFSNM CFSNM requested review from bdattoma and lugi0 May 21, 2024 14:44
@CFSNM CFSNM force-pushed the default_retry_subscription branch from 288085a to 8096c31 Compare May 22, 2024 14:23
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bdattoma bdattoma merged commit 214fdd4 into red-hat-data-services:master May 22, 2024
8 checks passed
@bdattoma bdattoma added the enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) label May 22, 2024
@CFSNM CFSNM deleted the default_retry_subscription branch May 22, 2024 14:33
CFSNM added a commit to CFSNM/ods-ci that referenced this pull request May 22, 2024
bdattoma pushed a commit that referenced this pull request May 22, 2024
…bscription Last Condition Is (#1475)

Bumping default retry to 150 in Wait Until Operator Subscription Last Condition Is (#1470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants