-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codeflare-sdk tests to run against latest release tag #1435
Update codeflare-sdk tests to run against latest release tag #1435
Conversation
${latest_tag} = Run Process curl -s "${CODEFLARE-SDK-API_URL}" | grep '"tag_name":' | cut -d '"' -f 4 | ||
... shell=True stderr=STDOUT | ||
Log To Console codeflare-sdk latest tag is : ${latest_tag.stdout} | ||
IF ${latest_tag.rc} != 0 |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
${result} = Run Process rm -rf ${CODEFLARE-SDK_DIR} | ||
... shell=true stderr=STDOUT | ||
Log To Console ${result.stdout} | ||
IF ${result.rc} != 0 |
Check notice
Code scanning / Robocop
'{{ block_name }}' condition can be simplified Note test
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Makes me think, is there a need to work with Git at all? Why not to install latest version directly from pip? |
Yes we can install either way , but for test execution we need the respective repo branch aswell |
ok, fine for me |
5769433
to
a307f2c
Compare
|
closes https://issues.redhat.com/browse/RHOAIENG-5070