Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeflare-sdk tests to run against latest release tag #1435

Merged
merged 1 commit into from
May 14, 2024

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented May 10, 2024

${latest_tag} = Run Process curl -s "${CODEFLARE-SDK-API_URL}" | grep '"tag_name":' | cut -d '"' -f 4
... shell=True stderr=STDOUT
Log To Console codeflare-sdk latest tag is : ${latest_tag.stdout}
IF ${latest_tag.rc} != 0

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'IF' condition can be simplified
${result} = Run Process rm -rf ${CODEFLARE-SDK_DIR}
... shell=true stderr=STDOUT
Log To Console ${result.stdout}
IF ${result.rc} != 0

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'IF' condition can be simplified
Copy link
Contributor

github-actions bot commented May 10, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
455 0 0 455 100

@Srihari1192 Srihari1192 marked this pull request as ready for review May 10, 2024 06:16
Copy link
Contributor

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sutaakar
Copy link
Contributor

Makes me think, is there a need to work with Git at all? Why not to install latest version directly from pip?

@Srihari1192
Copy link
Contributor Author

Makes me think, is there a need to work with Git at all? Why not to install latest version directly from pip?

Yes we can install either way , but for test execution we need the respective repo branch aswell

@sutaakar
Copy link
Contributor

ok, fine for me

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jiripetrlik jiripetrlik merged commit cc13d9d into red-hat-data-services:master May 14, 2024
8 checks passed
@Srihari1192 Srihari1192 deleted the RHOAIENG-5070 branch May 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants