Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "F403", # from python_terraform import * used; unable to detect undefined names #1424

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix "F403", # from python_terraform import * used; unable to detect undefined names #1424

merged 1 commit into from
May 14, 2024

Conversation

jiridanek
Copy link
Member

No description provided.

@jiridanek jiridanek added needs testing Needs to be tested in Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels May 7, 2024
@jiridanek jiridanek requested review from aloganat and jstourac May 7, 2024 10:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
455 0 0 455 100

@jiridanek
Copy link
Member Author

@aloganat confirmed this script is not currently used in CI, so I checked it by hand

  1. create ~/.config/openstack/clouds.yaml
  2. execute poetry run python /home/jdanek/repos/ods-ci/ods_ci/utils/scripts/terraform/openstack/provision.py create_instance --cloud_name=rhos-d --vm_name=jdanek --vm_user=jdanek --vm_private_key=cci --key_pair=cci --network_name=provider_net_cci_9
  3. check in webui that vm got created
  4. execute poetry run python /home/jdanek/repos/ods-ci/ods_ci/utils/scripts/terraform/openstack/provision.py delete_instance --cloud_name=rhos-d --vm_name=jdanek --key_pair=cci --network_name=provider_net_cci_9
  5. check vm got deleted

marking the PR as verified

@jiridanek
Fix "F403", # from python_terraform import * used; unable to detect…
6349d17 
… undefined names

Signed-off-by: Jiri Daněk <jdanek@redhat.com>
@jiridanek jiridanek force-pushed the jd_ruff_uber_alles branch from 89312ae to 6349d17 Compare May 13, 2024 13:41
@jiridanek jiridanek added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels May 13, 2024
@jiridanek jiridanek requested a review from kobihk May 13, 2024 13:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

aloganat
aloganat approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jiridanek jiridanek merged commit 50c1fed into red-hat-data-services:master May 14, 2024
8 checks passed
@jiridanek jiridanek deleted the jd_ruff_uber_alles branch May 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloganat aloganat aloganat approved these changes

@jstourac jstourac jstourac approved these changes

@kobihk kobihk Awaiting requested review from kobihk

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiridanek @aloganat @jstourac